Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote ShareProcessNamespace to beta #66507

Merged
merged 3 commits into from
Aug 9, 2018
Merged

Promote ShareProcessNamespace to beta #66507

merged 3 commits into from
Aug 9, 2018

Conversation

verb
Copy link
Contributor

@verb verb commented Jul 23, 2018 •
edited
Loading

What this PR does / why we need it: The ability to configure PID namespace sharing per-pod was added as an alpha feature in 1.10. This promotes the feature to beta and makes the feature available by default.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
WIP #1615

Special notes for your reviewer:
/assign @yujuhong

Release note:

The PodShareProcessNamespace feature to configure PID namespace sharing within a pod has been promoted to beta.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 23, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 23, 2018
@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jul 23, 2018
@k8s-ci-robot k8s-ci-robot requested review from davidopp and gmarek July 23, 2018 15:41
@BenTheElder BenTheElder mentioned this pull request Jul 23, 2018
Closed
@verb
Copy link
Contributor Author

verb commented Jul 23, 2018

/retest

@yujuhong
Copy link
Contributor

/lgtm
/retest

cc @kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jul 23, 2018
@yujuhong
Copy link
Contributor

/assign @dchen1107

@yujuhong
Copy link
Contributor

@verb the code should be removed in DropDisabledAlphaFields as well.

@yujuhong yujuhong removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2018
@yujuhong
Copy link
Contributor

Otherwise, lgtm.

@verb
Retain ShareProcessNamespace in pod storage
81a5ff9 
This field is no longer alpha, so don't drop it with the other alpha fields.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 24, 2018
@verb
Copy link
Contributor Author

verb commented Jul 24, 2018

@yujuhong sure thing. I removed the code from DropDisabledAlphaFields and left the check in validation.

@verb
Copy link
Contributor Author

verb commented Jul 24, 2018

/retest

yastij
yastij approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2018
@yastij
Copy link
Member

yastij commented Jul 24, 2018

/hold

Can @kubernetes/api-approvers take a look as we are moving sharedPID to beta ?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2018
@yujuhong
Copy link
Contributor

/lgtm

@tallclair
Copy link
Member

This promotes the feature to beta and enables it by default.

To clarify, this enables the feature to be used by default, it doesn't actually default ShareProcessNamespace to true. Right?

@verb
Copy link
Contributor Author

verb commented Jul 25, 2018

@tallclair Correct. The pod default is unchanged. If ShareProcessNamespace is not specified in pod config, isolated process namespaces are still used. This PR makes the feature available unless disabled with --feature-gate=PodShareProcessNamespace=false.

Sorry for the confusing wording, I will update the description.

@verb
Copy link
Contributor Author

verb commented Aug 8, 2018

/retest

@verb
Copy link
Contributor Author

verb commented Aug 8, 2018

@liggitt @smarterclayton commented on this in alpha. Can one of you review this for beta?

@yujuhong
Copy link
Contributor

yujuhong commented Aug 8, 2018

/assign @liggitt
/assign @smarterclayton

@dchen1107
Copy link
Member

/lgtm

@dchen1107
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, verb, yastij, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2018
@liggitt
Copy link
Member

liggitt commented Aug 8, 2018

@liggitt @smarterclayton commented on this in alpha. Can one of you review this for beta?

I don't have any objections, but don't have a good sense for what feedback we got on this. Will defer to sig-node

@verb
Copy link
Contributor Author

verb commented Aug 9, 2018

@liggitt deferred to sig-node for api-approvers. Since @dchen1107 gave approval for sig-node I'll go ahead and remove the hold.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 8ebc84e into kubernetes:master Aug 9, 2018
@haircommander haircommander mentioned this pull request Aug 22, 2018
Closed
@tpepper tpepper mentioned this pull request Sep 6, 2018
Closed
@mgdevstack mgdevstack mentioned this pull request Mar 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yastij yastij yastij approved these changes

@davidopp davidopp Awaiting requested review from davidopp

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@dchen1107 dchen1107

@yastij yastij

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@verb @yujuhong @yastij @tallclair @dchen1107 @k8s-ci-robot @liggitt @k8s-github-robot @smarterclayton