add Ceph FS volume plugin #6649

rootfs · 2015-04-09T20:02:30Z

this is functionally ready. I understand Endpoints is still under discussion.

vishh · 2015-04-09T20:04:21Z

examples/cephfs/endpoints/ceph-monitors.json

+        "10.16.154.82:0",
+        "10.16.154.83:0"
+    ]
+}


nit: Add new line.

vishh · 2015-04-09T20:07:33Z

pkg/volume/cephfs/cephfs.go

+func (plugin *cephfsPlugin) newBuilderInternal(spec *api.Volume, ep *api.Endpoints, podRef *api.ObjectReference, mounter mount.Interface, exe exec.Interface) (volume.Builder, error) {
+	id := spec.Cephfs.RadosUser
+	if id == "" {
+		id = "admin"


nit: Can you move all the strings to be const variables at the top of the file?

Why is this defaulted here and not in the API defaults files? There may be a legit reason, but I want to understand

vishh · 2015-04-09T20:19:00Z

Thanks for all the awesome work @rootfs. Just a few nits. I would really like to have end to end tests for these plugins. I opened a separate issue to discuss that.

erictune · 2015-04-14T16:24:23Z

pkg/api/types.go

+	// Optional: RadosUser is the rados user name, default is admin
+	RadosUser string `json:"user"`
+	// Optional: SecretFile is the path to key file for user, default is /etc/ceph/user.secret
+	SecretFile string `json:"secrete_file"`


s/secrete/secret

k8s-bot · 2015-05-22T00:04:19Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain @ixdy.

erictune · 2015-06-01T14:57:24Z

ok to test

thockin · 2015-06-01T21:06:37Z

I'm concerned that the 'secrets' issues in here are just not resolved - this needs to resolved ASAP or miss 1.0

rootfs · 2015-06-02T13:25:13Z

I thought I've missed the train. I'll shape it up soon.

rootfs · 2015-06-02T18:22:41Z

@vishh @thockin @smarterclayton @markturansky @pmorie

ready for your comments. Thanks

rootfs · 2015-06-02T19:40:47Z

@smarterclayton

k8s-bot · 2015-08-28T19:21:50Z

GCE e2e build/test passed for commit 8cb07c12b8ced14f8dc6909858edf110280abc28.

saad-ali · 2015-08-28T20:11:24Z

Thanks @rootfs One last file and then please squash your commits.

rootfs · 2015-08-28T20:28:26Z

@saad-ali squashed, wait for green :)

saad-ali · 2015-08-28T20:36:37Z

Thanks @rootfs

LGTM

@pmorie @markturansky if you're good, let's get this merged.

k8s-bot · 2015-08-28T21:03:38Z

GCE e2e build/test passed for commit 4a4c510e54b267320dca899f48f4c007386377f7.

markturansky · 2015-08-28T21:10:08Z

@saad-ali I took a look today. I think we're good to go. We can support it from here.

LGTM.

markturansky · 2015-08-28T21:15:40Z

@rootfs Not worth blocking this PR, but in #12599 Brian commented on your example (fiber channel) and said that YAML is preferred. Perhaps a follow-up PR to change these examples to YAML?

rootfs · 2015-08-28T21:25:26Z

@markturansky there are other json to yaml conversion in examples, let's get them in next PR(s)

markturansky · 2015-08-28T21:30:04Z

SGTM

saad-ali · 2015-09-01T04:50:55Z

Adding LGTM label

brendandburns · 2015-09-01T17:08:38Z

@rootfs needs rebase (sorry!)

Signed-off-by: Huamin Chen <hchen@redhat.com>

rootfs · 2015-09-01T18:05:54Z

@brendandburns done, thanks!

k8s-bot · 2015-09-01T18:22:16Z

GCE e2e build/test passed for commit 20c284a541ec391353b769314e033df2decca57b.

k8s-bot · 2015-09-01T18:23:40Z

GCE e2e build/test passed for commit dad1124b97f4026eb59b68b2da3aa6850646b083.

k8s-bot · 2015-09-01T18:30:49Z

GCE e2e build/test passed for commit fe559f2.

k8s-github-robot · 2015-09-01T23:10:12Z

Labelling this PR as size/XL

brendandburns · 2015-09-02T16:48:13Z

Merging since the github api flaked and this was skipped.

add Ceph FS volume plugin

googlebot added the cla: yes label Apr 9, 2015

vishh reviewed Apr 9, 2015
View reviewed changes

examples/cephfs/endpoints/ceph-monitors.json

"10.16.154.82:0",

"10.16.154.83:0"

]

}

Copy link

Contributor

vishh Apr 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add new line.

vishh self-assigned this Apr 9, 2015

vishh reviewed Apr 9, 2015
View reviewed changes

erictune reviewed Apr 14, 2015
View reviewed changes

erictune added this to the v1.0-post milestone Jun 1, 2015

rootfs force-pushed the wip-cephfs branch 6 times, most recently from 17a4257 to 2044fbd Compare June 2, 2015 18:16

rootfs force-pushed the wip-cephfs branch 2 times, most recently from 8d1b0c5 to 5df7b37 Compare June 2, 2015 19:10

rootfs force-pushed the wip-cephfs branch from f7dbe98 to 8cb07c1 Compare August 28, 2015 18:57

rootfs force-pushed the wip-cephfs branch from 8cb07c1 to 4a4c510 Compare August 28, 2015 20:28

saad-ali added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2015

rootfs force-pushed the wip-cephfs branch 2 times, most recently from dad1124 to 20c284a Compare September 1, 2015 18:00

implement Ceph FS volume plugin and add to e2e volume test

fe559f2

Signed-off-by: Huamin Chen <hchen@redhat.com>

rootfs force-pushed the wip-cephfs branch from 20c284a to fe559f2 Compare September 1, 2015 18:05

k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 1, 2015

rootfs mentioned this pull request Sep 2, 2015

support fibre channel volume #12599

Merged

brendandburns added a commit that referenced this pull request Sep 2, 2015

Merge pull request #6649 from rootfs/wip-cephfs

74ef517

add Ceph FS volume plugin

brendandburns merged commit 74ef517 into kubernetes:master Sep 2, 2015

saad-ali added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 11, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Ceph FS volume plugin #6649

add Ceph FS volume plugin #6649

rootfs commented Apr 9, 2015

vishh Apr 9, 2015

vishh Apr 9, 2015

thockin Apr 21, 2015

vishh commented Apr 9, 2015

erictune Apr 14, 2015

k8s-bot commented May 22, 2015

erictune commented Jun 1, 2015

thockin commented Jun 1, 2015

rootfs commented Jun 2, 2015

rootfs commented Jun 2, 2015

rootfs commented Jun 2, 2015

k8s-bot commented Aug 28, 2015

saad-ali commented Aug 28, 2015

rootfs commented Aug 28, 2015

saad-ali commented Aug 28, 2015

k8s-bot commented Aug 28, 2015

markturansky commented Aug 28, 2015

markturansky commented Aug 28, 2015

rootfs commented Aug 28, 2015

markturansky commented Aug 28, 2015

saad-ali commented Sep 1, 2015

brendandburns commented Sep 1, 2015

rootfs commented Sep 1, 2015

k8s-bot commented Sep 1, 2015

k8s-bot commented Sep 1, 2015

k8s-bot commented Sep 1, 2015

k8s-github-robot commented Sep 1, 2015

brendandburns commented Sep 2, 2015

add Ceph FS volume plugin #6649

add Ceph FS volume plugin #6649

Conversation

rootfs commented Apr 9, 2015

vishh Apr 9, 2015

Choose a reason for hiding this comment

vishh Apr 9, 2015

Choose a reason for hiding this comment

thockin Apr 21, 2015

Choose a reason for hiding this comment

vishh commented Apr 9, 2015

erictune Apr 14, 2015

Choose a reason for hiding this comment

k8s-bot commented May 22, 2015

erictune commented Jun 1, 2015

thockin commented Jun 1, 2015

rootfs commented Jun 2, 2015

rootfs commented Jun 2, 2015

rootfs commented Jun 2, 2015

k8s-bot commented Aug 28, 2015

saad-ali commented Aug 28, 2015

rootfs commented Aug 28, 2015

saad-ali commented Aug 28, 2015

k8s-bot commented Aug 28, 2015

markturansky commented Aug 28, 2015

markturansky commented Aug 28, 2015

rootfs commented Aug 28, 2015

markturansky commented Aug 28, 2015

saad-ali commented Sep 1, 2015

brendandburns commented Sep 1, 2015

rootfs commented Sep 1, 2015

k8s-bot commented Sep 1, 2015

k8s-bot commented Sep 1, 2015

k8s-bot commented Sep 1, 2015

k8s-github-robot commented Sep 1, 2015

brendandburns commented Sep 2, 2015