-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ip-masq-agent daemonset will be scheduled in all nodes. #66260
Conversation
Could you update the commit message? Instead of |
/assign @dchen1107 |
/lgtm @dchen1107 for approval |
/hold |
/retest |
1 similar comment
/retest |
@dchen1107 Friendly ping, should be really quick |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, dchen1107, tanshanshan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 66634, 66260). If you want to cherry-pick this change to another branch, please follow the instructions here. |
@tanshanshan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@tanshanshan Could you please add a release note to this PR, saying something like: Add NoSchedule/NoExecute tolerations to ip-masq-agent, ensuring it to be scheduled in all nodes except master. |
It's for cherrypicking the change into previous versions and I am not able to change the release note. |
/sig network |
…60-upstream-release-1.9 Automated cherry pick of #66260: Add NoSchedule and NoExecute tolerations to ip-masq-agent
What this PR does / why we need it:
ip-masq-agent tolerate NoSchedule and NoExecute so that it will be scheduled in all nodes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #66255
Special notes for your reviewer:
Release note: