Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip-masq-agent daemonset will be scheduled in all nodes. #66260

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

tanshanshan
Copy link

@tanshanshan tanshanshan commented Jul 17, 2018

What this PR does / why we need it:
ip-masq-agent tolerate NoSchedule and NoExecute so that it will be scheduled in all nodes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #66255

Special notes for your reviewer:

Release note:

Add NoSchedule/NoExecute tolerations to ip-masq-agent, ensuring it to be scheduled in all nodes except master.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 17, 2018
@k8s-ci-robot k8s-ci-robot requested review from bowei and dnardo July 17, 2018 01:52
@grayluck
Copy link
Contributor

Could you update the commit message?

Instead of fixtants, let's do a more informative comment message like Add NoSchedule and NoExecute tolerations to ip-masq-agent.

@grayluck
Copy link
Contributor

/assign @dchen1107

@bowei
Copy link
Member

bowei commented Aug 2, 2018

/lgtm

@dchen1107 for approval

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 2, 2018
@grayluck
Copy link
Contributor

grayluck commented Aug 2, 2018

/hold
Need someone to confirm that the tolerance is appropriate.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2018
@grayluck
Copy link
Contributor

grayluck commented Aug 3, 2018

/retest

1 similar comment
@grayluck
Copy link
Contributor

grayluck commented Aug 7, 2018

/retest

@grayluck
Copy link
Contributor

grayluck commented Aug 7, 2018

@dchen1107 Friendly ping, should be really quick

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, dchen1107, tanshanshan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grayluck
Copy link
Contributor

grayluck commented Aug 7, 2018

/hold cancel
Thanks guys! Buckle the seat belts.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 66634, 66260). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3c05d92 into kubernetes:master Aug 8, 2018
@k8s-ci-robot
Copy link
Contributor

@tanshanshan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration c8a4c65 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@grayluck
Copy link
Contributor

@tanshanshan Could you please add a release note to this PR, saying something like: Add NoSchedule/NoExecute tolerations to ip-masq-agent, ensuring it to be scheduled in all nodes except master.
Thanks!

@grayluck
Copy link
Contributor

It's for cherrypicking the change into previous versions and I am not able to change the release note.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 11, 2018
k8s-github-robot pushed a commit that referenced this pull request Aug 13, 2018
…60-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #66260: Add NoSchedule and NoExecute tolerations to ip-masq-agent

Cherry pick of #66260 on release-1.10.

#66260: Add NoSchedule and NoExecute tolerations to ip-masq-agent
@neolit123
Copy link
Member

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Aug 24, 2018
k8s-github-robot pushed a commit that referenced this pull request Aug 28, 2018
…60-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #66260: Add NoSchedule and NoExecute tolerations to ip-masq-agent

Cherry pick of #66260 on release-1.11.

#66260: Add NoSchedule and NoExecute tolerations to ip-masq-agent
k8s-ci-robot added a commit that referenced this pull request Sep 10, 2018
…60-upstream-release-1.9

Automated cherry pick of #66260: Add NoSchedule and NoExecute tolerations to ip-masq-agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ip-masq-agent has insufficient tolerations and is not being scheduled to all nodes
7 participants