Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go1.10.3 #65726

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Update to go1.10.3 #65726

merged 1 commit into from
Jul 3, 2018
+4 −4

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Jul 2, 2018 •
edited
Loading

What this PR does / why we need it: updates to build with go1.10.3; see list of changes here.

We'll probably want to cherrypick this to release-1.11 as well.

Release note:

Update to use go1.10.3

/assign @BenTheElder @cblecker

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 2, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2018
@ixdy
Copy link
Member Author

ixdy commented Jul 2, 2018

/release-note

@k8s-ci-robot
Copy link
Contributor

@ixdy: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 2, 2018
cblecker
cblecker reviewed Jul 2, 2018
View reviewed changes
hack/lib/golang.sh Outdated
@@ -336,7 +336,7 @@ EOF
local go_version
IFS=" " read -ra go_version <<< "$(go version)"
local minimum_go_version
minimum_go_version=go1.10.2
minimum_go_version=go1.10.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump the minimum here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not. I can revert this, since it'll make CI easier to update.

@ixdy ixdy force-pushed the golang-1.10.3 branch from 725bcd6 to 0333b8a Compare July 2, 2018 22:46
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2018
@cblecker
Copy link
Member

cblecker commented Jul 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 65677, 65711, 65150, 65726). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f29c130 into kubernetes:master Jul 3, 2018
@warmchang
Copy link
Contributor

Hi, may I ask what is the policy to update the Go lang compiler? Keep following the latest version?

@ixdy
Copy link
Member Author

ixdy commented Jul 6, 2018

@warmchang we generally try to keep up to date with the latest patch release (for example, 1.10.2 -> 1.10.3 here) for the relevant bug fixes.

We update to the latest minor release (for example, 1.9 -> 1.10) less aggressively, since there are often bugs or other issues to be worked out first, and we want to ensure enough time to soak test the new release, so we don't update close to the kubernetes release date.

This is why kubernetes 1.11 is the first release to use go1.10: while go1.10 was released prior to kubernetes 1.10 being released, it was too close to our cut.

@warmchang
Copy link
Contributor

Got it, thank you @ixdy !

@ixdy ixdy mentioned this pull request Jul 9, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 12, 2018
Merge pull request #65984 from ixdy/automated-cherry-pick-of-#65726-u…
edcd356 
…pstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #65726: Update to go1.10.3

Cherry pick of #65726 on release-1.11.

#65726: Update to go1.10.3
@marpaia
Copy link
Contributor

marpaia commented Jul 25, 2018

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker left review comments

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

Assignees

@BenTheElder BenTheElder

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ixdy @k8s-ci-robot @cblecker @k8s-github-robot @warmchang @marpaia @foxish @BenTheElder