Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate --use-openapi-print-columns in favor of --server-print #65601

Merged
merged 2 commits into from
Jun 29, 2018
Merged

deprecate --use-openapi-print-columns in favor of --server-print #65601

merged 2 commits into from
Jun 29, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 28, 2018 •
edited
Loading

server-side printing has been supported since 1.10 with identical output for core kubernetes types, support is available for extension API servers since 1.10, and for CRDs since 1.11.

openapi printing is mutually exclusive with server-side printing (you have to fetch full objects to do openapi printing, and table row output to do server side printing)

openapi printing has many downsides:

  • it requires fetching/parsing a very large schema on every get request
  • it requires complex object extraction logic be built into every client
  • it is limited to literal values that appear in the objects

see discussion of long-term direction between these two approaches in #53483

/sig cli

@kubernetes/sig-cli-pr-reviews
/assign @pwittrock @soltysh

kubectl: --use-openapi-print-columns is deprecated in favor of --server-print

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2018
@k8s-ci-robot k8s-ci-robot requested review from shiywang and vishh June 28, 2018 23:52
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 28, 2018
@liggitt liggitt added this to the v1.12 milestone Jun 28, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@liggitt @pwittrock @soltysh

Action required: This pull request requires label changes. If the required changes are not made within 3 days, the pull request will be moved out of the v1.12 milestone.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.

Help

@smarterclayton
Copy link
Contributor

SGTM, server side is a superset of openapi for all the use cases I'm aware of.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2018
soltysh
soltysh approved these changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 65319, 64513, 65474, 65601, 65634). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 21b960a into kubernetes:master Jun 29, 2018
@liggitt liggitt deleted the deprecate-openapi-column-printing branch July 4, 2018 00:35
@lukaszgryglicki lukaszgryglicki mentioned this pull request Jul 16, 2018
Closed
@ardaguclu ardaguclu mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@shiywang shiywang Awaiting requested review from shiywang

@vishh vishh Awaiting requested review from vishh

Assignees

@soltysh soltysh

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @k8s-github-robot @smarterclayton @k8s-ci-robot @soltysh @pwittrock