-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception detection in new version of fluentd-gcp addon #65361
Fix exception detection in new version of fluentd-gcp addon #65361
Conversation
/ok-to-test |
cc @bmoyles0117 @qingling128 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x13n, xperimental The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-gce |
/retest Review the full test history for this PR. Silence the bot with an |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 65361, 64527). If you want to cherry-pick this change to another branch, please follow the instructions here. |
@xperimental: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/sig gcp |
What this PR does / why we need it:
The
detect_exceptions
plugin is used to group log entries that belong to a common exception together into one log message. A recent change to the configuration modified which field is used for the log message, but this change was not applied to the configuration of thedetect_exceptions
plugin, so currently no collation of exception lines is happening.This change fixes the issue by changing the field the
detect_exceptions
plugin is using.Special notes for your reviewer:
Release note: