Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove item from taint manager workqueue on completion #65339

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Remove item from taint manager workqueue on completion #65339

merged 1 commit into from
Jun 22, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 21, 2018 •
edited
Loading

fixes a memory leak observed in the controller manager when creating/deleting pods containing tolerations

xref #65325

fixes a memory leak in the kube-controller-manager observed when large numbers of pods with tolerations are created/deleted

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2018
@liggitt liggitt force-pushed the taint-manager-memory branch from cbb1d19 to 8448ee4 Compare June 21, 2018 21:11
@liggitt
Copy link
Member Author

liggitt commented Jun 21, 2018

@kubernetes/sig-scheduling-bugs
/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 21, 2018
@liggitt liggitt mentioned this pull request Jun 21, 2018
Closed
@liggitt
Copy link
Member Author

liggitt commented Jun 21, 2018

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Jun 21, 2018

/retest

@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2018
@liggitt
Copy link
Member Author

liggitt commented Jun 21, 2018

/retest

@liggitt liggitt mentioned this pull request Jun 22, 2018
Merged
@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This was referenced Jun 22, 2018
Merged
Merged
Merged
Merged
@liggitt
Copy link
Member Author

liggitt commented Jun 22, 2018

/milestone v1.11
/status approved-for-milestone
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. status/approved-for-milestone labels Jun 22, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jun 22, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@liggitt @wojtek-t

Pull Request Labels
  • sig/scheduling: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@liggitt
Copy link
Member Author

liggitt commented Jun 22, 2018

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 65339, 65343, 65324, 65335, 65367). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit bece0d5 into kubernetes:master Jun 22, 2018
k8s-github-robot pushed a commit that referenced this pull request Jun 22, 2018
Merge pull request #65362 from liggitt/automated-cherry-pick-of-#6533…
914210e 
…9-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #65339: Remove item from taint manager workqueue on completion

Cherry pick of #65339 on release-1.11.

#65339: Remove item from taint manager workqueue on completion
k8s-github-robot pushed a commit that referenced this pull request Jun 22, 2018
Merge pull request #65364 from liggitt/automated-cherry-pick-of-#6533…
7527102 
…9-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #65339: Remove item from taint manager workqueue on completion

Cherry pick of #65339 on release-1.9.

#65339: Remove item from taint manager workqueue on completion
k8s-github-robot pushed a commit that referenced this pull request Jun 24, 2018
Merge pull request #65365 from liggitt/automated-cherry-pick-of-#6533…
ae0b392 
…9-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #65339: Remove item from taint manager workqueue on completion

Cherry pick of #65339 on release-1.8.

#65339: Remove item from taint manager workqueue on completion
k8s-github-robot pushed a commit that referenced this pull request Jun 25, 2018
Merge pull request #65363 from liggitt/automated-cherry-pick-of-#6533…
c97937e 
…9-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #65339: Remove item from taint manager workqueue on completion

Cherry pick of #65339 on release-1.10.

#65339: Remove item from taint manager workqueue on completion
@liggitt liggitt deleted the taint-manager-memory branch June 28, 2018 20:34
@brianmartin brianmartin mentioned this pull request Jul 3, 2018
Closed
@liggitt liggitt mentioned this pull request Jul 8, 2018
Closed
@kj187
Copy link

kj187 commented Aug 8, 2018

Thanks! Is this just fixed for kubernetes v1.11.x ?
Not v1.9.x or 1.8.x ?

@liggitt
Copy link
Member Author

liggitt commented Aug 8, 2018

fixes are in:

@kj187
Copy link

kj187 commented Aug 8, 2018

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @smarterclayton @wojtek-t @k8s-ci-robot @k8s-github-robot @kj187