Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exec/portforward minions->nodes #6516

Merged
merged 1 commit into from
Apr 7, 2015
Merged

Fix exec/portforward minions->nodes #6516

merged 1 commit into from
Apr 7, 2015

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Apr 7, 2015

Exec and port forward weren't working with v1beta3 because they were
proxying minions. Change minions to nodes. This appears to work with
v1beta1 and v1beta2 as well.

Fix exec/portforward minions->nodes
1c92133 
Exec and port forward weren't working with v1beta3 because they were
proxying minions. Change minions to nodes. This appears to work with
v1beta1 and v1beta2 as well.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ncdc
Copy link
Member Author

ncdc commented Apr 7, 2015

@smarterclayton PTAL

@smarterclayton
Copy link
Contributor

LGTM

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2015
smarterclayton added a commit that referenced this pull request Apr 7, 2015
@smarterclayton
Merge pull request #6516 from ncdc/fix-exec-portforward-proxy-resource
31b7f75 
Fix exec/portforward minions->nodes
@smarterclayton smarterclayton merged commit 31b7f75 into kubernetes:master Apr 7, 2015
@ncdc ncdc deleted the fix-exec-portforward-proxy-resource branch February 13, 2017 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncdc @googlebot @smarterclayton