Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few fixes of density test #6512

Merged
merged 1 commit into from
Apr 7, 2015
Merged

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Apr 7, 2015

This is a followup from #6459

  1. Change tests to be dependent of the size of the cluster (# of nodes)
  2. Fix the problem of incorrect arguments to "It"

cc @fgrzadkowski @rjnagal @jayunit100

@jayunit100
Copy link
Member

Thanks ! Looks good to me !

  • minor nit (not a holdup) I see you have differentiated density from launchPods.... seems however that there ir "raw density" and "relative density". - Later in a follow on we can rename these vars or add more comments.

By the way... what was the problem with It arguments ? I didnt notice one.... (update) looking closer, i guess youve removed need to access via indices?

@wojtek-t
Copy link
Member Author

wojtek-t commented Apr 7, 2015

@jayunit100
I've differentiated them, because those test are pretty different one from the other.
So what names are you suggesting? [I was never good at naming thing so I'm very open on any suggestions]

Regarding the "It" argument - this wasn't your bug - it was introduced by me before (but I didn't observe it). Basically it seems that "It" is not called synchronously so there is a problem of using variables from the outside that can change in the meantime inside "It".

@jayunit100
Copy link
Member

@wojtek-t
cool :) ... for names? I'd suggest podScalability and podDensity . but that can be done later.... no need to hold up this patch.

the names i suggest above give a good difference between the latter (which launches # pods per minion) and the former (which just launches N pods).

I say lets merge it if you've tested ... its a good update !

@wojtek-t
Copy link
Member Author

wojtek-t commented Apr 7, 2015

Thanks - renaming done.

@rjnagal
Copy link
Contributor

rjnagal commented Apr 7, 2015

Thanks @wojtek-t This looks great.

LGTM

rjnagal added a commit that referenced this pull request Apr 7, 2015
@rjnagal rjnagal merged commit 19af060 into kubernetes:master Apr 7, 2015
@wojtek-t wojtek-t deleted the fix_density_test branch April 9, 2015 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants