Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #64630: Wait a minimum amount of time for polling operations #65119

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Automated cherry pick of #64630: Wait a minimum amount of time for polling operations #65119

merged 2 commits into from
Jun 18, 2018

Conversation

nicksardo
Copy link
Contributor

Cherry pick of #64630 on release-1.10.

#64630: Wait a minimum amount of time for polling operations

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 14, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 14, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2018
@nicksardo nicksardo force-pushed the automated-cherry-pick-of-#64630-upstream-release-1.10 branch from 7123f2e to 01443fc Compare June 14, 2018 21:27
@nicksardo nicksardo force-pushed the automated-cherry-pick-of-#64630-upstream-release-1.10 branch from 01443fc to 1f336dd Compare June 14, 2018 21:38
@nicksardo
Copy link
Contributor Author

/uncc zmerlynn dchen1107
/cc bowei

@k8s-ci-robot k8s-ci-robot requested review from bowei and removed request for zmerlynn and dchen1107 June 14, 2018 21:47
@nicksardo
Copy link
Contributor Author

nicksardo commented Jun 14, 2018 •
edited
Loading

/sig gcp
/kind bug

@k8s-ci-robot k8s-ci-robot added sig/gcp kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jun 14, 2018
@k8s-ci-robot
Copy link
Contributor

@nicksardo: Those labels are not set on the issue: sig/network

In response to this:

/remove-sig network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jun 18, 2018
@MaciekPytel MaciekPytel added this to the v1.10 milestone Jun 18, 2018
@MaciekPytel MaciekPytel added status/approved-for-milestone priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jun 18, 2018
@MaciekPytel
Copy link
Contributor

@nicksardo @bowei This must be reviewed today if you want it to be included in 1.10.5.

@bowei
Copy link
Member

bowei commented Jun 18, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, nicksardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@bowei @nicksardo

Pull Request Labels
  • sig/gcp: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit a21d351 into kubernetes:release-1.10 Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@nicksardo @k8s-ci-robot @MaciekPytel @bowei @k8s-github-robot