set EnableHTTPSTrafficOnly in azure storage account creation #64957
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
sig/azure
kind/feature
k8s-ci-robot
added
cncf-cla: yes
andyzhangx
changed the title
|
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
|
/assign @feiskyer |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kubernetes-e2e-gce |
|
/test pull-kubernetes-integration |
|
Automatic merge from submit-queue (batch tested with PRs 64895, 64938, 63700, 65050, 64957). If you want to cherry-pick this change to another branch, please follow the instructions here. |
This was referenced Jul 9, 2018
Merged
Merged
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 10, 2018
…4957-upstream-release-1.9 Automated cherry pick of #64957: set EnableHTTPSTrafficOnly in storageAccount creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
PEN test shows there is security risk if https traffic is not enabled by default
Enforce azure storage account creation with https traffic only, this PR will apply for both azure disk & azure file features.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #64956
Special notes for your reviewer:
Tests with azure disk & azure file all pass
Release note:
/sig azure
/kind feature
/assign @khenidak