Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kubeconfig serialization #6476

Merged
merged 3 commits into from
Apr 9, 2015
Merged

fix kubeconfig serialization #6476

merged 3 commits into from
Apr 9, 2015

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 6, 2015

Partially addresses #5625.

This updates kubectl config view to produce the output based on the serialization format instead of the in memory copy.

I attempted to do this before, but I failed to handle the different templates that already existed and that resulted in e2e failures. This time I've update the templates in the scripts (see the update scripts with correct templates commit). I'm running e2e now, but the individual formats were equivalent when I tested them. See https://gist.github.com/deads2k/c294a882c9358ea7679f for how I located them and what the equivalence was.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@deads2k deads2k mentioned this pull request Apr 6, 2015
Closed
@j3ffml
Copy link
Contributor

j3ffml commented Apr 7, 2015

LGTM, provided e2e is passing. It's unfortunate that this makes kubectl config view -o template even harder to use; the template was tricky to read before, it's now practically inscrutable. Still useful for scripting, but pretty user-unfriendly.

@deads2k deads2k force-pushed the deads-fix-kubeconfig-serialization branch from 2298a2b to 06c9dbd Compare April 7, 2015 13:30
@deads2k
Copy link
Contributor Author

deads2k commented Apr 7, 2015

Rebased to get vagrant e2e working again.

I got most of them passing on vagrant. I get the same success/failures on master against vagrant.

Summarizing 4 Failures:

[Fail] Services [It] should be able to create a functioning external load balancer 
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/service.go:282

[Fail] Services [It] should correctly serve identically named services in different namespaces on different external IP addresses 
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/service.go:373

[Fail] kubectl guestbook [It] should create and stop a working application 
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/util.go:304

[Fail] Shell [It] tests that services.sh passes 
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/shell.go:67

Ran 32 of 37 Specs in 822.676 seconds
FAIL! -- 28 Passed | 4 Failed | 0 Pending | 5 Skipped F0407 09:05:55.975617    9536 driver.go:112] At least one test failed

@deads2k deads2k mentioned this pull request Apr 8, 2015
Merged
@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2015
j3ffml added a commit that referenced this pull request Apr 9, 2015
@j3ffml
Merge pull request #6476 from deads2k/deads-fix-kubeconfig-serialization
ca6f1a1 
fix kubeconfig serialization
@j3ffml j3ffml merged commit ca6f1a1 into kubernetes:master Apr 9, 2015
@deads2k deads2k mentioned this pull request Apr 9, 2015
Merged
@deads2k deads2k deleted the deads-fix-kubeconfig-serialization branch June 11, 2015 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deads2k @googlebot @j3ffml