Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE: Update cloud provider to use TPU v1 API #64727

Merged
merged 2 commits into from
Jun 6, 2018
Merged

GCE: Update cloud provider to use TPU v1 API #64727

merged 2 commits into from
Jun 6, 2018

Conversation

yguo0905
Copy link
Contributor

@yguo0905 yguo0905 commented Jun 4, 2018

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

GCE: Update cloud provider to use TPU v1 API

/assign @vishh
/assign @cheftako

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 4, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 4, 2018
@yguo0905
Copy link
Contributor Author

yguo0905 commented Jun 5, 2018

/test pull-kubernetes-integration

@vishh
Copy link
Contributor

vishh commented Jun 5, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2018
@vishh vishh added this to the v1.11 milestone Jun 5, 2018
@vishh vishh added the sig/gcp label Jun 5, 2018
@yguo0905
Copy link
Contributor Author

yguo0905 commented Jun 5, 2018

/assign @thockin

@tpepper
Copy link
Member

tpepper commented Jun 5, 2018

FYI: This PR is not marked as priority/critical-urgent. As such, it will be removed from the 1.11 milestone by the milestone bot when Code Freeze starts at midnight UTC / 5pm PDT. If you feel it is critical to 1.11, please upgrade its priority to critical-urgent.

@thockin
Copy link
Member

thockin commented Jun 5, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, vishh, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2018
@vishh vishh added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 5, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@cheftako @thockin @vishh @yguo0905

Action required: This pull request requires label changes.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.

Help

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 64009, 64780, 64354, 64727, 63650). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 81b5db9 into kubernetes:master Jun 6, 2018
@yguo0905 yguo0905 mentioned this pull request Jun 6, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 11, 2018
Merge pull request #64848 from yguo0905/automated-cherry-pick-of-#647…
0e7c3d6 
…27-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #64727: Update GCE cloud provider to use Cloud TPU v1 API

Cherry pick of #64727 on release-1.10.

#64727: Update GCE cloud provider to use Cloud TPU v1 API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@jdef jdef Awaiting requested review from jdef

Assignees

@cheftako cheftako

@thockin thockin

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
7 participants
@yguo0905 @vishh @tpepper @thockin @k8s-ci-robot @k8s-github-robot @cheftako