Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore delete watch event for setup instance in CRD testing #64726

Closed
wants to merge 1 commit into from
Closed

Ignore delete watch event for setup instance in CRD testing #64726

wants to merge 1 commit into from

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented Jun 4, 2018

During CRD testing setup, a setup instance CRD is created and watched to make sure the watch cache to sync up. The deletion (and potentially creation) watch event for this instance can result in test failure for any watch test as they expect exact watch events.

Fixes #64571

@mbohlool mbohlool requested review from sttts and liggitt June 4, 2018 21:48
@k8s-ci-robot
Copy link
Contributor

@mbohlool: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 4, 2018
@k8s-ci-robot k8s-ci-robot requested a review from enisoc June 4, 2018 21:48
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbohlool
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lavalamp

Assign the PR to them by writing /assign @lavalamp in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 4, 2018
@liggitt
Copy link
Member

liggitt commented Jun 5, 2018

During CRD testing setup, a setup instance CRD is created and watched to make sure the watch cache to sync up.

discussed offline... I think it would make more sense to change checkForWatchCachePrimed to do the delete synchronously, start the watch at the resourceVersion of the created instance, and wait for the delete event. that lets all of this test code avoid object and watch event pollution from the test setup

@liggitt liggitt mentioned this pull request Jun 5, 2018
Merged
@mbohlool
Copy link
Contributor Author

mbohlool commented Jun 5, 2018

close in favor of #64796

@mbohlool mbohlool closed this Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

@liggitt liggitt Awaiting requested review from liggitt

@enisoc enisoc Awaiting requested review from enisoc

Assignees

@liggitt liggitt

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbohlool @k8s-ci-robot @liggitt