-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print nodes for those metrics is somehow unreachable #64389
print nodes for those metrics is somehow unreachable #64389
Conversation
/kind bug |
overall LGTM. I am not quite sure whether we should use |
Looks good to me :-D thanks |
@adohe Thanks. Seems like there's no such a centric definition as
Note that <unknown> is hardcoded across the project (both in client and server) without a centric definition. As of now, I think we could just print it hardcodedly like previous implementation before someone come up with a PR solving this mess. And such a PR should make some changes to "server-side print" together.
|
cool~ let's just keep using |
/assign @adohe |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adohe, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
3 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
Automatic merge from submit-queue (batch tested with PRs 64882, 64692, 64389, 60626, 64840). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
When we use
kubectl top nodes
, some nodes will be ignored when their metrics cannot be fetched from metrics serve. It might be misleading for users.This PR helps print the missing nodes like:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #63986
Special notes for your reviewer:
Release note: