First hack at upgrade script for GCE #6427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mbforbes |
| @@ -82,6 +73,19 @@ for k,v in yaml.load(sys.stdin).iteritems(): | |||
| fi | |||
| } | |||
|
|
|||
| function maybe-get-kube-token() { | |||
There was a problem hiding this comment.
I think ensure- is the convention for these semantics? I think it's also a little clearer.
|
Thanks, Zach. Looking good mod comments; ping me when you've addressed them. Will be great to get to start testing this out (& I can hack on the nodes part as soon as this is in). |
Address kubernetes#6075: Shoot the master VM while saving the master-pd. This takes a couple of minor changes to configure-vm.sh, some of which also would be necessary for reboot. In particular, I changed it so that the kube-token instance metadata is no longer required after inception; instead, we mount the master-pd and see if we've already created the known tokens file before blocking on the instance metadata. Also partially addresses kubernetes#6099 in bash by refactoring the kube-push path.
|
PTAL. I think I addressed your comments, except the refactoring of the master init and the bangs. |
|
I played around with that refactor and agree it looks fine. So, yes, TOTAL PTAL. |
|
(I kept it on a separate commit for easier reviewability, though.) |
mbforbes
added
lgtm
|
LGTM |
rjnagal
added a commit
that referenced
this pull request
Apr 6, 2015
First hack at upgrade script for GCE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #6075: Shoot the master VM while saving the master-pd. This
takes a couple of minor changes to configure-vm.sh, some of which also
would be necessary for reboot. In particular, I changed it so that the
kube-token instance metadata is no longer required after inception;
instead, we mount the master-pd and see if we've already created the
known tokens file before blocking on the instance metadata.
Also partially addresses #6099 in bash by refactoring the kube-push
path.