Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reason message logs for non-exist Azure resources #64248

Merged
merged 1 commit into from
May 25, 2018
Merged

Add reason message logs for non-exist Azure resources #64248

merged 1 commit into from
May 25, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented May 24, 2018 •
edited
Loading

What this PR does / why we need it:

In azure_wrap.go the function checkResourceExistsFromError() looks at a received error and determines it to be a ResourceNotFound if the HTTP status is http.StatusNotFound. However, the HTTP status also equals http.StatusNotFound in case of SubscriptionNotFound.

this PR adds logs to indict the real error messages for such case.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #64220

Special notes for your reviewer:

Release note:

Add reason message logs for non-exist Azure resources

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 24, 2018
feiskyer
feiskyer commented May 24, 2018
View reviewed changes
pkg/cloudprovider/providers/azure/azure_wrap.go
}
if v.StatusCode == http.StatusNotFound {
return false, nil
return false, err.Error(), nil
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, there is a Message filed in autorest.DetailedError, but its contents are always same. So the error itself is used here

@feiskyer
Copy link
Member Author

/sig azure

@andyzhangx
Copy link
Member

the code looks strange to me, if realErr is nil, why there is errMessage, may be infoMsg ?

exists, errMessage, realErr := checkResourceExistsFromError(err)

@feiskyer
Copy link
Member Author

@andyzhangx Renamed errMessage to message . PTAL

andyzhangx
andyzhangx approved these changes May 24, 2018
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 63319, 64248, 64250, 63890, 64233). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 696430d into kubernetes:master May 25, 2018
@feiskyer feiskyer deleted the exact-err-msg branch May 25, 2018 03:04
@feiskyer feiskyer restored the exact-err-msg branch July 20, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@colemickens colemickens Awaiting requested review from colemickens

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure SubscriptionNotFound is silently changed to cloudprovider.InstanceNotFound
4 participants
@feiskyer @andyzhangx @k8s-ci-robot @k8s-github-robot