Fix incorrect reference to name in v1beta3 API. #6423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks for catching this. |
bgrant0607
added a commit
that referenced
this pull request
Apr 3, 2015
Fix incorrect reference to name in v1beta3 API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only look at the second commit, the first is in #6373.
@bgrant0607 Unfortunately, we wrote "name" instead of "metadata.name" in our field selector for v1beta3. This PR rectifies that, but of course is a breaking change. I'm not sure if anyone uses this yet. It's up to you how to proceed.