Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Etcd listens on localhost for GCE #6417

Merged
merged 1 commit into from
Apr 3, 2015
Merged

Etcd listens on localhost for GCE #6417

merged 1 commit into from
Apr 3, 2015

Conversation

ArtfulCoder
Copy link
Contributor

#5962

Will roll out the change to other cloud providers after GCE.
#5011

@ArtfulCoder
Copy link
Contributor Author

Running e2e tests.

@zmerlynn
Copy link
Member

zmerlynn commented Apr 3, 2015

LGTM. Thanks!

zmerlynn added a commit that referenced this pull request Apr 3, 2015
@zmerlynn
Merge pull request #6417 from ArtfulCoder/local_etcd
98bf5ae 
Etcd listens on localhost for GCE
@zmerlynn zmerlynn merged commit 98bf5ae into kubernetes:master Apr 3, 2015
@zmerlynn
Copy link
Member

zmerlynn commented Apr 3, 2015

Ha, sorry. Just saw the "Running e2e."

... hopefully that works. :)

@ArtfulCoder
Copy link
Contributor Author

yes :)
will track the e2e jenkins run as well.

@ArtfulCoder
Copy link
Contributor Author

http://kubekins.dls.corp.google.com/job/kubernetes-e2e-gce/4142/consoleFull

All tests, except 1 passed.
Will look at the failing test but I doubt it is related to my change.

Summarizing 1 Failure:

[Fail] ReplicationController [It] should serve a basic image on each replica with a private image
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/rc.go:151

Ran 31 of 35 Specs in 1107.520 seconds
FAIL! -- 30 Passed | 1 Failed | 0 Pending | 4 Skipped F0403 12:55:29.517718 24805 driver.go:112] At least one test failed
2015/04/03 12:55:29 Error running Ginkgo tests: exit status 255

@ArtfulCoder
Copy link
Contributor Author

Per Quinton's test summary email today, it is a flaky test with a 70% stability.

This PR should be good.

@ArtfulCoder
Copy link
Contributor Author

@dchen1107

@ArtfulCoder
Copy link
Contributor Author

@brendanburns @zmerlynn Can I make changes for "etcd on localhost" on all providers ?
Or do you forsee any issues ?

GCE seems to be doing well, e2e and manual tests passed.

@ArtfulCoder ArtfulCoder mentioned this pull request Apr 3, 2015
Closed
@zmerlynn
Copy link
Member

zmerlynn commented Apr 3, 2015

I'm actually fine with that. I nearly changed it once before, but the change it was in was wide enough already.

@ArtfulCoder
Copy link
Contributor Author

Created PR #6422

@roberthbailey roberthbailey mentioned this pull request Apr 27, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtfulCoder @zmerlynn @googlebot