Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct test logging package stackdrvier -> stackdriver #64112

Merged
merged 1 commit into from
May 22, 2018

Conversation

BenTheElder
Copy link
Member

What this PR does / why we need it: corrects the name of the stackdriver logging test package

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 21, 2018
@k8s-ci-robot k8s-ci-robot requested review from coffeepac and piosz May 21, 2018 19:04
@BenTheElder
Copy link
Member Author

/cc @serathius @krzyzacy

@k8s-ci-robot k8s-ci-robot requested a review from krzyzacy May 21, 2018 19:04
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: GitHub didn't allow me to request PR reviews from the following users: serathius.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @serathius @krzyzacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krzyzacy
Copy link
Member

/shrug
/lgtm

@k8s-ci-robot k8s-ci-robot added ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 21, 2018
@krzyzacy
Copy link
Member

/assign @piosz

@BenTheElder
Copy link
Member Author

BenTheElder commented May 21, 2018 via email

@coffeepac
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, coffeepac, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2018
@BenTheElder
Copy link
Member Author

/retest

2 similar comments
@BenTheElder
Copy link
Member Author

/retest

@BenTheElder
Copy link
Member Author

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 7136cbc into kubernetes:master May 22, 2018
@BenTheElder BenTheElder deleted the stackdrvier branch May 22, 2018 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants