Unbreak minion watch on kubelet #6401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't run e2e yet, addresses #6395 |
|
LGTM, merging to fix the break |
|
As a follow up, we should add a test case to catch it. |
smarterclayton
added a commit
that referenced
this pull request
Apr 3, 2015
Unbreak minion watch on kubelet
|
Thanks for fixing it @bprashanth ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we watch against a minion/ endpoint, registering field selectors needs to happen against the
kindof the resource, which is the name go reports for it's type (the type returned by theNewfunction of its storage). In the case of minions, the storage is minion/etcd and the type is api.Node, so the kind is Node not Minion.