Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic is admission options is nil #63993

Merged
merged 1 commit into from
May 24, 2018
Merged

Don't panic is admission options is nil #63993

merged 1 commit into from
May 24, 2018

Conversation

tamalsaha
Copy link
Member

@tamalsaha tamalsaha commented May 17, 2018 •
edited by deads2k
Loading

Backport #63460

cc: @sttts @deads2k

nil admission options are now consistent with other nil options.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2018
@k8s-ci-robot k8s-ci-robot requested review from cjcullen and liggitt May 17, 2018 18:49
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 17, 2018
@tamalsaha tamalsaha mentioned this pull request May 17, 2018
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 17, 2018
@deads2k
Copy link
Contributor

deads2k commented May 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, tamalsaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2018
@tamalsaha
Copy link
Member Author

tamalsaha commented May 17, 2018 •
edited
Loading

@deads2k , this needs cherrypick-approved label.

@sttts
Copy link
Contributor

sttts commented May 18, 2018

@tamalsaha from https://github.com/kubernetes/sig-release/blob/master/releases/release-1.10/release_team.md: AFAIK @MaciekPytel is the one tagging cherry-pick for patch releases.

@MaciekPytel
Copy link
Contributor

This looks like a good cherrypick and I will approve it. However, we're in branch freeze to get enough test signal for 1.10.3 (which is planned for Monday). I'll add the labels after 1.10.3 is out. Please ping me directly if you think this is critical enough that it must go in 1.10.3 (and risk delaying the release).

Ps. @tamalsaha it's fine for this PR, but please use hack/cherry_pick_pull.sh script to create future cherrypicks.

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels May 24, 2018
@MaciekPytel
Copy link
Contributor

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit ca8dea7 into kubernetes:release-1.10 May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcullen cjcullen Awaiting requested review from cjcullen

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tamalsaha @deads2k @k8s-ci-robot @sttts @MaciekPytel @fejta-bot @k8s-github-robot