Use same addons script for init.d and systemd. #6384
Merged
+29
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing with kube-up.sh in progress. |
|
cc @derekwaynecarr, you may want to test this too |
|
I just merged #6382 which fixed vagrant after yesterday's changes with etcd in pod. If it's not urgent, I cannot test this until early next week (out tomorrow). |
| # $2 count of tries to start the addon. | ||
| # $3 delay in seconds between two consecutive tries | ||
| function start_addon() { | ||
| addon=$1; |
There was a problem hiding this comment.
Make these locals in this PR and save some time in the other? :)
|
LGTM except minor nit (and obviously testing) |
|
Tested by running kube-up and verifying all addons started. |
|
Not going to fix nit since I already tested it and don't want to wait for another round of testing. |
|
K. :) |
zmerlynn
added a commit
that referenced
this pull request
Apr 2, 2015
Use same addons script for init.d and systemd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.