integration: Fix multiple response.WriteHeader calls #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current integration tests do not return after delegating HTTP requests, as a result an extra call to response.WriteHeader is made for every request. Fix the issue by returning after delegating HTTP requests.
|
Awesome, that explains why I couldn't find it in apiserver... (BTW--if you write "closes #563" somewhere in your description, it'll auto-close the issue when we merge.) |
|
I'll add the auto close line in the future. |
lavalamp
added a commit
that referenced
this pull request
Jul 26, 2014
…ite_headers integration: Fix multiple response.WriteHeader calls
seans3
pushed a commit
to seans3/kubernetes
that referenced
this pull request
Apr 10, 2019
The Great KEP Migration of 2018
wking
pushed a commit
to wking/kubernetes
that referenced
this pull request
Jul 21, 2020
Book: update labeling recommendations
rphillips
pushed a commit
to rphillips/kubernetes
that referenced
this pull request
Apr 8, 2021
…localhost-support KS with preferred host support
linxiulei
pushed a commit
to linxiulei/kubernetes
that referenced
this pull request
Jan 18, 2024
Add vteratipally as an approver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current integration tests do not return after delegating
HTTP requests, as a result an extra call to response.WriteHeader
is made for every request.
Fix the issue by returning after delegating HTTP requests.