Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DisruptedPods in PodDisruptionBudgetStatus optional field #63757

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Make DisruptedPods in PodDisruptionBudgetStatus optional field #63757

merged 2 commits into from
Aug 22, 2018

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented May 13, 2018 •
edited
Loading

What this PR does / why we need it:

Please refer to #63756

Which issue(s) this PR fixes

Fixes #63756

Release note:

`DisruptedPods` field in `PodDisruptionBudget` is optional instead of required.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2018
@k8s-ci-robot k8s-ci-robot requested review from mfojtik and tallclair May 13, 2018 05:03
@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 13, 2018
@kragniz
Copy link
Member

kragniz commented May 13, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2018
@tallclair
Copy link
Member

/unassign
/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label May 15, 2018
@nak3
Copy link
Contributor Author

nak3 commented May 25, 2018

/test pull-kubernetes-verify

@nikhita
Copy link
Member

nikhita commented Aug 11, 2018

/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt August 11, 2018 08:41
@nak3
Copy link
Contributor Author

nak3 commented Aug 13, 2018

Just rebased.

@tallclair tallclair removed their request for review August 14, 2018 00:48
liggitt
liggitt reviewed Aug 21, 2018
View reviewed changes
staging/src/k8s.io/api/policy/v1beta1/types.go Outdated
@@ -60,6 +60,7 @@ type PodDisruptionBudgetStatus struct {
// the list automatically by PodDisruptionBudget controller after some time.
// If everything goes smooth this map should be empty for the most of the time.
// Large number of entries in the map may indicate problems with pod deletions.
// +optional
DisruptedPods map[string]metav1.Time `json:"disruptedPods" protobuf:"bytes,2,rep,name=disruptedPods"`
Copy link
Member

@liggitt liggitt Aug 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is optional, it should also set omitempty in the json options. that would mean this field would no longer be serialized as disruptedPods: null and would instead be omitted entirely.

nikhita
nikhita reviewed Aug 21, 2018
View reviewed changes
pkg/apis/policy/types.go
@@ -63,6 +63,7 @@ type PodDisruptionBudgetStatus struct {
// the list automatically by PodDisruptionBudget controller after some time.
// If everything goes smooth this map should be empty for the most of the time.
// Large number of entries in the map may indicate problems with pod deletions.
// +optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt is this comment useful for internal types as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of anything that gets generated off the internal types, so I don't think so

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 22, 2018
@nak3
Copy link
Contributor Author

nak3 commented Aug 22, 2018

/test pull-kubernetes-integration

@nak3
Copy link
Contributor Author

nak3 commented Aug 22, 2018

@liggitt Thank you. Updated.

@liggitt
Copy link
Member

liggitt commented Aug 22, 2018

thanks, please squash down the commits, then LGTM

@liggitt
Copy link
Member

liggitt commented Aug 22, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2018
@nikhita
Copy link
Member

nikhita commented Aug 22, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

@nak3: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration 811bdbd link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 63757, 67698, 67712, 67494, 67700). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit e98bf0f into kubernetes:master Aug 22, 2018
@nak3 nak3 deleted the disruptedPods-optional branch August 22, 2018 23:37
@nikhita
Copy link
Member

nikhita commented Sep 12, 2018

This should have a release note. @nak3 can you update the main PR body to include a release note?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 12, 2018
@nak3
Copy link
Contributor Author

nak3 commented Sep 12, 2018

@nikhita Sure, done.

@ultimateboy ultimateboy mentioned this pull request Oct 12, 2018
Merged
@liggitt liggitt mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@liggitt liggitt liggitt left review comments

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
7 participants
@nak3 @kragniz @tallclair @nikhita @liggitt @k8s-ci-robot @k8s-github-robot