Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hack/build-go.sh to work on all platforms #637

Merged
merged 1 commit into from
Jul 26, 2014

Conversation

kelseyhightower
Copy link
Contributor

Currently the hack/build-go.sh build script does not work
on OS X 10.9.x systems. This changes reverts back to building
one binary via a for loop.

Currently the hack/build-go.sh build script does not work
on OS X 10.9.x systems. This changes reverts back to building
one binary via a for loop.
@kelseyhightower
Copy link
Contributor Author

This PR should fix #632

@lavalamp
Copy link
Member

Thanks for the quick fix!

lavalamp added a commit that referenced this pull request Jul 26, 2014
Fix hack/build-go.sh to work on all platforms
@lavalamp lavalamp merged commit d102b9c into kubernetes:master Jul 26, 2014
@smarterclayton
Copy link
Contributor

Hrm - the change I committed worked on:

$ bash --version
bash --version
GNU bash, version 3.2.51(1)-release (x86_64-apple-darwin13)

What shell were you running in?

EDIT: realized it was go build vs install

vishh pushed a commit to vishh/kubernetes that referenced this pull request Apr 6, 2016
Rebase cAdvisor to the new libcontainer.
ehashman pushed a commit to ehashman/kubernetes that referenced this pull request Mar 24, 2021
upstream: 99817: Fix zero-value custom resource validation with go1.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants