Redo on building platforms in parallel #6369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @brendanburns @roberthbailey Care to test on OS X? |
|
Re-fixes #6346 |
|
Wait, what!? Seriously, needs a rebase since this morning!? |
|
n/m, I put up a branch that didn't have the revert-revert in first. Should be mergable now. |
|
Just tested on OS X and this works the same as before (serial builds since my virtual box VM has less than 8G of memory). |
…ckaging phases of `make release`"" This reverts commit 9f60dde.
a function (to make it kinder on reviewers for the next piece).
|
@brendandburns: You were complaining about not having enough to review, so I fixed #6389 and cleaned up the Docker container build spew, too, while I was working on doc'ing Salt. |
|
LGTM. |
brendandburns
added a commit
that referenced
this pull request
Apr 3, 2015
Redo on building platforms in parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only build in parallel on >8G machines (as an arbitrary line in the sand).
Also parallelizes tarball builds further, as a freebie.