Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport MAX_PODS_PER_NODE env from #63114 to 1.10 #63621

Merged
merged 1 commit into from
May 15, 2018
Merged

Backport MAX_PODS_PER_NODE env from #63114 to 1.10 #63621

merged 1 commit into from
May 15, 2018

Conversation

grayluck
Copy link
Contributor

@grayluck grayluck commented May 9, 2018 •
edited
Loading

What this PR does / why we need it:
Backport MAX_PODS_PER_NODE env changes from #63114 to 1.10. This allows GCE/GKE users to explicitly set default limits on how many pods a node can have for the nodes in this cluster.

Special notes for your reviewer:
/assign @bowei

Release note:

Add MAX_PODS_PER_NODE env so that GCE/GKE user can use it to specify the default max pods per node for the cluster. IP_ALIAS_SIZE will be changed accordingly. Must have ip alias enabled.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 9, 2018
@k8s-ci-robot k8s-ci-robot requested review from bowei and MaciekPytel May 9, 2018 20:25
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 9, 2018
@grayluck
Copy link
Contributor Author

grayluck commented May 9, 2018

Manual test passed. MAX_PODS_PER_NODE=60 goes to the nodes as a --max-pods=60 flag of kubelet.

@grayluck grayluck changed the title Backport MAX_PODS_PER_NODE env from #63114 to 1.8 Backport MAX_PODS_PER_NODE env from #63114 to 1.10 May 10, 2018
@grayluck grayluck force-pushed the env-back-1.10 branch 2 times, most recently from e2260a0 to 5590b2a Compare May 10, 2018 17:01
@grayluck
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 10, 2018
@bowei
Copy link
Member

bowei commented May 13, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, grayluck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2018
@bowei
Copy link
Member

bowei commented May 13, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2018
@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels May 14, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@grayluck
Copy link
Contributor Author

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 5601a25 into kubernetes:release-1.10 May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grayluck @bowei @k8s-ci-robot @fejta-bot @k8s-github-robot @MaciekPytel