Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support for VM name with extra Separator String #63526

Merged
merged 1 commit into from
May 8, 2018
Merged

adding support for VM name with extra Separator String #63526

merged 1 commit into from
May 8, 2018

Conversation

djsly
Copy link
Contributor

@djsly djsly commented May 8, 2018

What this PR does / why we need it:
Allows the Azure VM name to have within their name the _ character

Special notes for your reviewer:
This is the error I got before testing

May 07 21:55:14 kn-infra000000.<domainname> kubelet[39465]: I0507 21:55:14.462125   39465 azure_vmss.go:108] getVmssVM gets scaleSetName ("kn-infra_ss") and instanceID ("0") for node "kn-infra000000"
May 07 21:55:14 kn-infra000000.<domainname> kubelet[39465]: E0507 21:55:14.462147   39465 azure_vmss_cache.go:52] Failed to extract vmssVMName "kn-infra_ss_0"
May 07 21:55:14 kn-infra000000.<domainname> kubelet[39465]: F0507 21:55:14.462160   39465 kubelet.go:1349] Kubelet failed to get node info: failed to get external ID from cloud provider: not a vmss instance

Release note:

Azure VMSS: support VM names to contain the `_` character

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2018
@djsly
Copy link
Contributor Author

djsly commented May 8, 2018

/assign @feiskyer

@djsly
Copy link
Contributor Author

djsly commented May 8, 2018 •
edited
Loading

/sig azure

@k8s-ci-robot k8s-ci-robot requested review from feiskyer and jdumars May 8, 2018 02:35
@djsly
Copy link
Contributor Author

djsly commented May 8, 2018

/cherrypick-candidate

@djsly
Copy link
Contributor Author

djsly commented May 8, 2018 •
edited
Loading

/milestone v1.10

@k8s-ci-robot
Copy link
Contributor

@djsly: You must be a member of the kubernetes-milestone-maintainers github team to set the milestone.

In response to this:

/milestone 1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer
Copy link
Member

feiskyer commented May 8, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2018
@feiskyer
Copy link
Member

feiskyer commented May 8, 2018

/retest

@feiskyer
Copy link
Member

feiskyer commented May 8, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 8, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@djsly djsly force-pushed the fix-vmss-parsing branch from bd2bdf3 to a8de002 Compare May 8, 2018 10:36
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2018
@feiskyer
Copy link
Member

feiskyer commented May 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djsly, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djsly
Copy link
Contributor Author

djsly commented May 8, 2018

@feiskyer thanks for the /lgmt, are you able to set the /milestone v1.10 and the cheerypick candidate ?

@feiskyer
Copy link
Member

feiskyer commented May 8, 2018

/milestone v1.10

@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone May 8, 2018
@feiskyer
Copy link
Member

feiskyer commented May 8, 2018

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 8, 2018
@feiskyer
Copy link
Member

feiskyer commented May 8, 2018

/retest

@feiskyer
Copy link
Member

feiskyer commented May 8, 2018

/status approved-for-milestone

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@djsly @feiskyer

Pull Request Labels
  • sig/azure: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@djsly
Copy link
Contributor Author

djsly commented May 8, 2018

/test pull-kubernetes-e2e-gce

1 similar comment
@djsly
Copy link
Contributor Author

djsly commented May 8, 2018

/test pull-kubernetes-e2e-gce

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit b00d600 into kubernetes:master May 8, 2018
@djsly djsly mentioned this pull request May 9, 2018
Merged
@djsly djsly deleted the fix-vmss-parsing branch May 9, 2018 12:28
k8s-github-robot pushed a commit that referenced this pull request May 9, 2018
Merge pull request #63566 from djsly/automated-cherry-pick-of-#63526-…
42ce74e 
…upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #63526: adding support for VM name with extra Separator String

Cherry pick of #63526 on release-1.10.

#63526: adding support for VM name with extra Separator String
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@jdumars jdumars Awaiting requested review from jdumars

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@djsly @k8s-ci-robot @feiskyer @fejta-bot @k8s-github-robot