Update openapi and doc to reflect 202 path in API server delete handler #63418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XL
roycaihw
changed the title
k8s-ci-robot
added
release-note
|
/sig api-machinery |
k8s-ci-robot
added
the
sig/api-machinery
|
/test pull-kubernetes-e2e-kops-aws |
|
/uncc |
|
/assign @mbohlool |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
roycaihw
force-pushed
the
openapi-delete-path
branch
from
f2359e0 to
cd18e5e
Compare
k8s-ci-robot
removed
the
lgtm
roycaihw
force-pushed
the
openapi-delete-path
branch
from
cd18e5e to
0ff4351
Compare
|
/retest |
roycaihw
force-pushed
the
openapi-delete-path
branch
from
0ff4351 to
cb2860a
Compare
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/retest |
1 similar comment
|
/retest |
roycaihw
force-pushed
the
openapi-delete-path
branch
from
cb2860a to
9ad6d72
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mbohlool, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Our API server returns 202 Accepted if a delete operation is asynchronous, but it is not reflected in our openapi spec and documentation. This PR adds 202 path in endpoint installer and updates our openapi spec and docs. The change in openapi spec may affect some clients that depend on the error paths. Python client only depends on response type, which is not changed in this PR. Sending this PR to see if it breaks client-go.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):ref #33196
Special notes for your reviewer:
Release note: