Reorder/Modularize networking e2e + pod launch phase, clean up comments. #6341
Conversation
|
fixing collision now with refactored |
jayunit100
force-pushed
the
networking-test-reorder
branch
from
e76a41d to
bab2788
Compare
|
ok @satnam6502 and @bgrant0607 .... finally here is theupdated pr. i killed the old one as it got broken by a conflicted commits + a messed up rebase on my end. this is the updated pr. Thanks ! |
|
Re-assigning for a quicker review :-) |
|
@piosz feel free to bounce this back to me and I shall try to get to it on Thursday. |
| }) | ||
|
|
||
| func LaunchNetTestPodPerNode(nodes *api.NodeList, name string, c *client.Client, ns string) []string { | ||
|
|
There was a problem hiding this comment.
Please add a By statement here. Also remove this empty line.
|
Okay, i implemented the fixes and comments inline. Regarding "peers" its not x-1, its x. The reason is that the service endpoints array actually returns all endpoints, so each node is a peer of itself, by definition. i will test this later e2e's are not run in the CI, so we should be careful before we merge it ! :) |
|
yup, tests pass :) rebasing and pushing. thanks for the fast review. |
…ts, rebase (comments).
jayunit100
force-pushed
the
networking-test-reorder
branch
from
a026240 to
3ad7557
Compare
|
Yes, thanks to @piosz for letting us exploit a time zone difference to our advantage :-) |
|
LGTM. Thanks for the change. @satnam6502 could you please do merge since I won't be online anymore? |
piosz
added
the
lgtm
Reorder/Modularize networking e2e + pod launch phase, clean up comments.
Creating a new PR, the other seemed to die on me.