Skip cleaning docker cache prior to build #6339
Merged
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| docker ps -aq | xargs -r docker rm | ||
| docker images -q | xargs -r docker rmi | ||
| # docker ps -aq | xargs -r docker rm | ||
| # docker images -q | xargs -r docker rmi |
There was a problem hiding this comment.
Add a comment to explain what the commented out lines do, and why someone might want to uncomment them.
Other than that, LGTM.
|
LGTM barring the one minor nit about a comment. Can be merged. |
This seems to be more trouble than its worth, and much of the remaining build time (except the push itself). We can cache the cross-build/golang images between builds - it's not going to kill us, and it'll save the occasional weird flake of not finding an image when it tries to rm one of these.
|
Added a comment. |
ghost
pushed a commit
that referenced
this pull request
Apr 2, 2015
Skip cleaning docker cache prior to build
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be more trouble than its worth, and much of
the remaining build time (except the push itself). We can
cache the cross-build/golang images between builds - it's
not going to kill us, and it'll save the occasional weird
flake of not finding an image when it tries to rm one of
these.