Check to prevent split brain api-servers/api-clients which can happen if... #6330
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if etcd dies between rerun of local-up-cluster.sh
brendandburns
added
the
lgtm
jszczepkowski
added a commit
that referenced
this pull request
Apr 2, 2015
Check to prevent split brain api-servers/api-clients which can happen if...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some different ways where local-up-cluster can mess you up when developing....
For example:
then:
To prevent this its super important to do a quick check that the API port isnt ALREADY being served on. This really messed me up today when I was trying to test some updates from head and i found that they weren't expressed in my local kube-apiserver , after a while, i realized, it was because kube-apiserver was indeed floating around already from a previous run of local-up-cluster.