Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting for kubelet memcg notification threshold #63220

Merged
merged 1 commit into from
May 16, 2018
Merged

Fix formatting for kubelet memcg notification threshold #63220

merged 1 commit into from
May 16, 2018

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Apr 27, 2018 •
edited
Loading

/kind bug
What this PR does / why we need it:
This fixes the following errors (found in this node_e2e serial test log):
eviction_manager.go:256] eviction manager attempting to integrate with kernel memcg notification api
threshold_notifier_linux.go:70] eviction: setting notification threshold to 4828488Ki
eviction_manager.go:272] eviction manager: failed to create hard memory threshold notifier: invalid argument

Special notes for your reviewer:
This needs to be cherrypicked back to 1.10.
This regression was added in #60531, because the quantity being used was changed from a DecimalSI to BinarySI, which changes how it is printed out in the String() method. To make it more explicit that we want the value, just convert Value() to a string.

Release note:

Fix memory cgroup notifications, and reduce associated log spam.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 27, 2018
@dashpole
Copy link
Contributor Author

/sig node
/assign @dchen1107

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 27, 2018
@dashpole
Copy link
Contributor Author

cc @derekwaynecarr

@dashpole
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 27, 2018
@dashpole
Copy link
Contributor Author

/retest

@dchen1107 dchen1107 added this to the v1.10 milestone Apr 27, 2018
feiskyer
feiskyer reviewed May 4, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Removed From Pull Request

@dashpole @dchen1107 @feiskyer @kubernetes/sig-node-misc

Important: This pull request was missing the status/approved-for-milestone label for more than 7 days.

Help

@k8s-github-robot k8s-github-robot removed this from the v1.10 milestone May 5, 2018
@dashpole
Copy link
Contributor Author

/assign @vishh
for approval

@vishh
Copy link
Contributor

vishh commented May 16, 2018

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, feiskyer, vishh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit c7bfc2a into kubernetes:master May 16, 2018
@dashpole dashpole mentioned this pull request May 17, 2018
Merged
@dashpole dashpole deleted the fix_memcg_format branch May 17, 2018 17:25
k8s-github-robot pushed a commit that referenced this pull request May 18, 2018
Merge pull request #63988 from dashpole/automated-cherry-pick-of-#632…
f962da3 
…20-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #63220: fix formatting for memcg threshold

Cherry pick of #63220 on release-1.10.

#63220: fix formatting for memcg threshold
@dashpole dashpole mentioned this pull request May 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@resouer resouer Awaiting requested review from resouer

Assignees

@feiskyer feiskyer

@vishh vishh

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dashpole @k8s-github-robot @vishh @k8s-ci-robot @feiskyer @dchen1107