Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

I'm part of the RedHat CLA.

@smarterclayton ptal.

LGTM

I think you need to gendocs

It's breaking on a lot of pulls - I assumed someone else would fix because bens code doesn't change the cli

On Apr 1, 2015, at 7:37 PM, Prashanth B notifications@github.com wrote:

I think you need to gendocs

—
Reply to this email directly or view it on GitHub.

Fair enough, i think it's fixed, i kicked shippable and travis will merge if they finish green

Looks like the failures are legit:

_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/apiserver/handlers_test.go:45: cannot use rl (type fakeRL) as type util.RateLimiter in argument to RateLimit:
    fakeRL does not implement util.RateLimiter (missing Accept method)

thanks @bprashanth, missed that. updated.

added a unit test for the new behavior.

@smarterclayton @bprashanth the travis errors look flaky and unrelated to my changes, any advice?

That looks like #6199, i kicked travis, we'll see

Shippable passing is usually enough.