Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #63000: Remove METADATA_AGENT_VERSION config option #63131

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Automated cherry pick of #63000: Remove METADATA_AGENT_VERSION config option #63131

merged 1 commit into from
Apr 25, 2018

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Apr 25, 2018

Cherry pick of #63000 on release-1.10.

#63000: Remove METADATA_AGENT_VERSION config option

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 25, 2018
@k8s-ci-robot k8s-ci-robot requested review from mwielgus and piosz April 25, 2018 08:01
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2018
@kawych
Copy link
Contributor Author

kawych commented Apr 25, 2018

/uncc @mwielgus
/cc @loburm @MaciekPytel

@k8s-ci-robot k8s-ci-robot requested review from loburm and MaciekPytel and removed request for mwielgus April 25, 2018 08:01
@loburm
Copy link
Contributor

loburm commented Apr 25, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 25, 2018
@kawych
Copy link
Contributor Author

kawych commented Apr 25, 2018

/retest

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 25, 2018
@MaciekPytel
Copy link
Contributor

/approve
(for cluster/gce)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, loburm, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2018
@MaciekPytel
Copy link
Contributor

/test pull-kubernetes-e2e-gke

@kawych
Copy link
Contributor Author

kawych commented Apr 25, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 25, 2018 •
edited
Loading

@kawych: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gke a85d0f3 link /test pull-kubernetes-e2e-gke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MaciekPytel MaciekPytel added this to the v1.10 milestone Apr 25, 2018
@MaciekPytel MaciekPytel added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Apr 25, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@kawych @loburm

Action required: This pull request requires label changes.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
sig owner: Must specify at least one label prefixed with sig/.

Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit f8473ed into kubernetes:release-1.10 Apr 25, 2018
@kawych kawych deleted the automated-cherry-pick-of-#63000-upstream-release-1.10 branch March 29, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piosz piosz Awaiting requested review from piosz

@loburm loburm Awaiting requested review from loburm

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@loburm loburm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@kawych @loburm @MaciekPytel @k8s-ci-robot @k8s-github-robot