Make expose use introspection to grab the port value if possible. #6312
+192
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jeff, because kubectl |
| if len(ports) == 0 { | ||
| return util.UsageError(cmd, "couldn't find a suitable port via --port flag or introspection") | ||
| } | ||
| params["port"] = ports[0] |
There was a problem hiding this comment.
This means expose will introspect and select the port of the first container in the case of a multi-container pod. If that is the intended behavior, it should be documented in the help string, though tbh, I think you should fail here if there is more than one port, as we don't know what the user actually intends.
brendandburns
force-pushed
the
services
branch
2 times, most recently
from
cfaf847 to
674efe6
Compare
Also improve service printing to include public IP addresses.
|
Comments addressed. ptal. |
|
LGTM. Will merge on green. |
j3ffml
added
the
lgtm
j3ffml
added a commit
that referenced
this pull request
Apr 2, 2015
Make expose use introspection to grab the port value if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve service printing to include public IP addresses.