Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bash command for liveness probes in the metadata agents. #63033

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Fix bash command for liveness probes in the metadata agents. #63033

merged 1 commit into from
Apr 24, 2018

Conversation

bmoyles0117
Copy link
Contributor

What this PR does / why we need it:
This PR resolves an error in the way that the bash liveness probe is defined.

Release note:

Fix the liveness probe to use `/bin/bash -c` instead of `/bin/bash c`.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2018
@bmoyles0117 bmoyles0117 mentioned this pull request Apr 23, 2018
Closed
@k8s-ci-robot k8s-ci-robot requested review from kawych and piosz April 23, 2018 19:49
@rphillips
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2018
@kawych
Copy link
Contributor

kawych commented Apr 24, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmoyles0117, kawych

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2018
@kawych
Copy link
Contributor

kawych commented Apr 24, 2018

/retest

1 similar comment
@kawych
Copy link
Contributor

kawych commented Apr 24, 2018

/retest

@kawych
Copy link
Contributor

kawych commented Apr 24, 2018

/test pull-kubernetes-integration

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 63033, 62993). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6917ed4 into kubernetes:master Apr 24, 2018
@kawych kawych mentioned this pull request Apr 24, 2018
Merged
@kawych
Copy link
Contributor

kawych commented Apr 24, 2018

@bmoyles0117
I've created a cherrry-pick to get it reviewed today: #63080 and merged asap.

@k8s-ci-robot
Copy link
Contributor

@bmoyles0117: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration e2beef5 link /test pull-kubernetes-integration
pull-kubernetes-verify e2beef5 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-github-robot pushed a commit that referenced this pull request Apr 24, 2018
Merge pull request #63080 from kawych/automated-cherry-pick-of-#63033…
bdb3e8a 
…-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #63033: Fix bash command for liveness probes in the metadata agents.

Cherry pick of #63033 on release-1.10.

#63033: Fix bash command for liveness probes in the metadata agents.
@bboreham
Copy link
Contributor

Can I recommend that the release note for this change include some context about which liveness probe you have changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kawych kawych Awaiting requested review from kawych

@piosz piosz Awaiting requested review from piosz

Assignees

@kawych kawych

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bmoyles0117 @rphillips @kawych @k8s-ci-robot @k8s-github-robot @bboreham