Remove salt configuration that matches the default settings in the Kubelet. #6298
+3
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dchen1107 (still running e2e on this -- don't merge yet) |
roberthbailey
force-pushed
the
kubelet-config
branch
from
90304fa to
40ebed8
Compare
|
My e2es passed locally (except for the monitoring test that I broke in my earlier PR and hadn't been rolled back before I started this e2e run). |
|
LGTM |
dchen1107
added a commit
that referenced
this pull request
Apr 1, 2015
Remove salt configuration that matches the default settings in the Kubelet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eventual goal is to have as little of the Kubelet configuration as possible specified as command line flags, and to move it to cluster-specific configuration settings that are obtained from the master.