Abstract IsMountPoint and improve FakeMounter #6269
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
CLAs look good, thanks! |
ddysher
force-pushed
the
extend-mount
branch
2 times, most recently
from
3f9c15f to
3e509a8
Compare
ddysher
changed the title
|
Assigning to @vishh, feel free to reassign. |
| func (mounter *Mounter) Mount(source string, target string, fstype string, flags uintptr, data string) error { | ||
| glog.V(5).Infof("Mounting %s %s %s %d %s", source, target, fstype, flags, data) | ||
| return syscall.Mount(source, target, fstype, flags, data) | ||
| } | ||
|
|
||
| // Wraps syscall.Unmount() | ||
| // Unmount Wraps syscall.Unmount() |
There was a problem hiding this comment.
tiniest of nits: "Wraps" in both comments should be lowercase "w"
ddysher
force-pushed
the
extend-mount
branch
2 times, most recently
from
4a4ea0e to
d62afa8
Compare
ddysher
changed the title
|
LGTM |
Abstract IsMountPoint and improve FakeMounter
Related #5658