Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm Salt grains.master_ip #6262

Merged
merged 1 commit into from
Apr 1, 2015
Merged

Conversation

zmerlynn
Copy link
Member

@zmerlynn zmerlynn commented Apr 1, 2015

This appears in the Salt documentation, is set by Vagrant, but has no
consumers. Remove vestigial references.

This appears in the Salt documentation, is set by Vagrant, but has no
consumers. Remove vestigial references.
@zmerlynn
Copy link
Member Author

zmerlynn commented Apr 1, 2015

I'm sure Derek loves being my Vagrant Salt guinea pig.

@derekwaynecarr
Copy link
Member

This used to be used. I need to go back and see when I no longer required it. It was probably after the Kubelet stopped going direct to etcd

@zmerlynn
Copy link
Member Author

zmerlynn commented Apr 1, 2015

I'm mainly just doing some house-cleaning. I was walkign through salt.md trying to figure out the inputs to our existing SaltStack and was scratching my head at some of these. (Will put a PR later with doc changes, of course.)

@derekwaynecarr
Copy link
Member

Did my own grep for master_ip and looks like its usage was removed.

LGTM

derekwaynecarr added a commit that referenced this pull request Apr 1, 2015
@derekwaynecarr derekwaynecarr merged commit 762c449 into kubernetes:master Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants