Build all commands at the same time #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Go it's much more efficient to build several commands in the same
`go build` because the build has to load most of the dependency tree
each time. Roughly 50% on my machine:
Together (go1.2 on OS X):
real 0m4.049s
user 0m8.387s
sys 0m2.766s
Separate:
real 0m13.392s
user 0m12.420s
sys 0m6.882s
| echo "+++ Building ${b}" | ||
| go build "${KUBE_GO_PACKAGE}"/cmd/${b} | ||
| done | ||
| go build $(for b in $BINARIES; do echo "${KUBE_GO_PACKAGE}"/cmd/${b}; done) |
There was a problem hiding this comment.
Something that's been bugging me for a while is that test-go.sh takes package names with a preceding pkg/ but build-go.sh adds an implied cmd/. Since you're changing this anyway, could you remove the implied cmd/ here? (That way tab autocomplete works ;) )
Update places that depend on it.
|
LGTM |
brendandburns
added a commit
that referenced
this pull request
Jul 25, 2014
Build all commands at the same time
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
Fix build. change event.Event to info.Event.
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Dec 8, 2016
Fixed kubernetes#589: when rebooting, failed to start sshd service after kube-down
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Mar 3, 2017
Fixed kubernetes#589: when rebooting, failed to start sshd service after kube-down
wking
pushed a commit
to wking/kubernetes
that referenced
this pull request
Jul 21, 2020
Dockerfile for GitBook
sanchezl
pushed a commit
to sanchezl/kubernetes
that referenced
this pull request
Mar 22, 2021
Ensure multi-az test is run in the serial job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Go it's much more efficient to build several commands in the same
go buildbecause the build has to load most of the dependency treeeach time. Roughly 50% on my machine:
Together (go1.2 on OS X):
Separate: