Eliminate grains.cloud_provider (in preference to grains.cloud) from SaltStack #6259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning to @derekwaynecarr, feel free to reassign. |
| {% set cloud_provider = "--cloud_provider=" + grains.cloud -%} | ||
|
|
||
| {% if grains.cloud == 'aws' -%} | ||
| {% set cloud_config = "--cloud_config=/etc/aws.conf" -%} |
There was a problem hiding this comment.
line 38 rewrites cloud config to empty string...
you need to move that line above this line so it has an initially empty value and is not reset later in file.
…SaltStack This variable can be entirely derived from grains.cloud, and it simplifies the configuration somewhat. (Or someone convince me I'm wrong. I'm happy to be wrong here.)
zmerlynn
force-pushed
the
fix_cloud_provider
branch
from
bb6d0ff
to
b581320
Compare
|
Fixed. PTAL. |
|
LGTM |
derekwaynecarr
added a commit
that referenced
this pull request
Apr 1, 2015
Eliminate grains.cloud_provider (in preference to grains.cloud) from SaltStack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable can be entirely derived from grains.cloud, and it
simplifies the configuration somewhat. (Or someone convince me I'm
wrong. I'm happy to be wrong here.)