Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private mount propagation #62462

Merged
merged 2 commits into from
Apr 13, 2018
Merged

Private mount propagation #62462

merged 2 commits into from
Apr 13, 2018

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Apr 12, 2018 •
edited by liggitt
Loading

This PR changes the default mount propagation from "rslave" (newly added in 1.10) to "private" (default in 1.9 and before). "rslave" as default causes regressions, see below.

Value "None" has to be added to MountPropagationMode enum in API ("I don't want any propagation at all"), which translates to "private" on Linux. We did not have use cases for it, but we have them now.

Which issue(s) this PR fixes
Fixes #62397, fixes #62396

Special notes for your reviewer:
CRI already has an option for private mount propagation in volumes, however it's called "PRIVATE", while Kubernetes API value is "None". I did not change PRIVATE to NONE to keep the interface stable. See kubelet_pods.go.

Release note:

Default mount propagation has changed from "HostToContainer" ("rslave" in Linux terminology) to "None" ("private") to match the behavior in 1.9 and earlier releases. "HostToContainer" as a default caused regressions in some pods.

/sig storage
/sig node

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 12, 2018
@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Apr 12, 2018
@jsafrane
Copy link
Member Author

@thockin, please look at the API.

@tallclair, can I ask you to look at kubelet changes? Thanks! FYI, the ultimate plan is to cherry-pick it to 1.10.x, i.e. we're changing the default behavior in patch release. I consider it to be a bugfix.

@jsafrane jsafrane force-pushed the private-mount-propagation branch from 7ab55cc to a943fdd Compare April 12, 2018 13:56
@saad-ali
Copy link
Member

/lgtm
/approve

For API review:
/assign @thockin

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2018
@saad-ali
Copy link
Member

saad-ali commented Apr 12, 2018 •
edited
Loading

@thockin is out-of-office. Can we get @smarterclayton to review/approve API changes?

@jsafrane
Copy link
Member Author

@liggitt, as @thockin is on PTO these days, would you mind approving the API change and validation?

@liggitt
Copy link
Member

liggitt commented Apr 13, 2018

@kubernetes/sig-storage-api-reviews

@liggitt
Copy link
Member

liggitt commented Apr 13, 2018

IIUC, this API field was added in 1.10, and this is adding an additional allowed value that matches the default behavior in 1.9, and making it the default when the field is unspecified?

do you plan to pick this to 1.10.x as well?

@jsafrane
Copy link
Member Author

IIUC, this API field was added in 1.10, and this is adding an additional allowed value that matches the default behavior in 1.9, and making it the default when the field is unspecified?

Yes

do you plan to pick this to 1.10.x as well?

Yes! That's the goal.

@liggitt
Copy link
Member

liggitt commented Apr 13, 2018

/lgtm

derekwaynecarr
derekwaynecarr approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, jsafrane, liggitt, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 60476, 62462, 61391, 62535, 62394). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 9206540 into kubernetes:master Apr 13, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 13, 2018 •
edited
Loading

@jsafrane: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce a943fdd link /test pull-kubernetes-kubemark-e2e-gce
pull-kubernetes-node-e2e a943fdd link /test pull-kubernetes-node-e2e
pull-kubernetes-verify a943fdd link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This was referenced Apr 16, 2018
Merged
Merged
@brancz brancz mentioned this pull request Apr 17, 2018
Closed
k8s-github-robot pushed a commit that referenced this pull request Apr 30, 2018
Merge pull request #62633 from jsafrane/automated-cherry-pick-of-#624…
18f4924 
…62-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62462: Add private mount propagation to API.

Cherry pick of #62462 on release-1.10.

#62462: Add private mount propagation to API.
@msau42 msau42 mentioned this pull request Jul 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr derekwaynecarr approved these changes

Assignees

@liggitt liggitt

@thockin thockin

@saad-ali saad-ali

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MountPropagation breaks Kubernetes on macOS MountPropagation breaks fluentd container
8 participants
@jsafrane @saad-ali @liggitt @k8s-ci-robot @k8s-github-robot @derekwaynecarr @thockin @tallclair