Fix Namespace Termination #6246
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
derekwaynecarr
force-pushed
the
finalize_fix
branch
from
d2c7afe to
bb4bc3b
Compare
|
Assigning @smarterclayton, feel free to reassign. |
|
@smarterclayton - i will ping to review this PR, want to add a little more testing. |
|
K, was about to ask for that |
derekwaynecarr
force-pushed
the
finalize_fix
branch
from
bb4bc3b to
275f459
Compare
|
@smarterclayton - this should be good to go now functionally, i added an extra validation test with mutiple finalizers... if we want to unblock the bug, we can merge this now, and i will follow-up tomorrow with more testing to ensure no future regression. |
| oldNamespace.Spec.Finalizers = namespace.Spec.Finalizers | ||
|
|
||
| oldNamespace.Labels = namespace.Labels | ||
| oldNamespace.Annotations = namespace.Annotations |
There was a problem hiding this comment.
this is what happens when you are rushing to fix something before leaving work ;-)
cleaning this up more this morning and getting more tests for various strategies.
derekwaynecarr
force-pushed
the
finalize_fix
branch
from
275f459 to
b745f51
Compare
|
@smarterclayton - added tests for each of the strategies that they are doing the right thing, and fixed where we had flipped old and new on validateNamespaceUpdate call. |
|
LGTM |
Fix Namespace Termination
There was a regression as part of the PrepareForUpdate changes that prevented deletion of a namespace because the list of finalizers was never being reduced because we were always taking the input from the client and overriding it with the old value from the server.
This change fixes the following:
/cc @smarterclayton