Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cadvisor client package which includes my fix for #608 #624

Merged
merged 1 commit into from
Jul 25, 2014

Conversation

dchen1107
Copy link
Member

No description provided.

@smarterclayton
Copy link
Contributor

I don't see the commit message from third_party/update.sh - was this manual? I think you need to redo this using those scripts.

@lavalamp
Copy link
Member

Yeah, I feel better seeing that "bump" message... Specific instructions:

  • Revert this change (git reset --hard HEAD~1 iirc)
  • Verify you've got no changed files in your repo (git status)
  • Run: third_party/update.sh github.com/google/cadvisor/client

@dchen1107
Copy link
Member Author

Ok I re-create the PR. My initial one is not manual, I just did a squash removing bump message. :-)

I tested it earlier this morning, and now we really have cAdvisor client created, and could retrieve stats from cAdvisor object.

@smarterclayton
Copy link
Contributor

LGTM

lavalamp added a commit that referenced this pull request Jul 25, 2014
update cadvisor client package which includes my fix for #608
@lavalamp lavalamp merged commit 6b5690a into kubernetes:master Jul 25, 2014
@lavalamp
Copy link
Member

Thanks for the fix!

@dchen1107 dchen1107 deleted the cadvisor branch October 22, 2014 21:45
vishh pushed a commit to vishh/kubernetes that referenced this pull request Apr 6, 2016
mqliang pushed a commit to mqliang/kubernetes that referenced this pull request Dec 8, 2016
mqliang pushed a commit to mqliang/kubernetes that referenced this pull request Mar 3, 2017
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
Remove cp examples from the port-forward page
b3atlesfan pushed a commit to b3atlesfan/kubernetes that referenced this pull request Feb 5, 2021
Only record routes in memory if not already there

Fixes kubernetes#624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants