Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "git: Use VolumeHost.GetExec() to execute stuff in volume plugins" #62394

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Revert "git: Use VolumeHost.GetExec() to execute stuff in volume plugins" #62394

merged 1 commit into from
Apr 13, 2018

Conversation

jsafrane
Copy link
Member

This reverts commit c578542 (PR #51098). The PR added support for containerized git, on the other hand it required git 1.8.5. This breaks git volumes on older distros (CentOS 7, Ubuntu 14.04) that have old git.

Git volumes are getting deprecated (#60999) so we should restore it to the last working state and not touch it any longer.

Release note:

gitRepo volumes in pods no longer require git 1.8.5 or newer, older git versions are supported too now.

I'd like to cherry-pick it into 1.10.

/sig storage

@jsafrane
Revert "git: Use VolumeHost.GetExec() to execute stuff in volume plug…
d761528 
…ins"

This reverts commit c578542.

Older distros (centos 7, ubuntu 14.04) use older git than required by
the reverted patch.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 11, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2018
@jsafrane
Copy link
Member Author

/retest

@jsafrane
Copy link
Member Author

@rootfs, you reviewed the original PR, can you please look at this one?

@jsafrane
Copy link
Member Author

@saad-ali, this is another thing that I'd like to fix in 1.10.x - I give up with mount container for git, it's deprecated and users can use init containers with the same effect. So let's roll back my changes, make git volume working everywhere and don't touch it.

@jsafrane
Copy link
Member Author

/assign @rootfs

@childsb
Copy link
Contributor

childsb commented Apr 13, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 60476, 62462, 61391, 62535, 62394). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3e4268f into kubernetes:master Apr 13, 2018
This was referenced Apr 16, 2018
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 18, 2018
Merge pull request #62622 from jsafrane/automated-cherry-pick-of-#623…
b256956 
…94-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62394: Revert "git: Use VolumeHost.GetExec() to execute stuff in

Cherry pick of #62394 on release-1.10.

#62394: Revert "git: Use VolumeHost.GetExec() to execute stuff in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@childsb childsb

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsafrane @childsb @k8s-ci-robot @k8s-github-robot @rootfs