Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix umask to actually intended behavior. #62301

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Fix umask to actually intended behavior. #62301

merged 1 commit into from
Apr 10, 2018

Conversation

filbranden
Copy link
Contributor

@filbranden filbranden commented Apr 9, 2018 •
edited
Loading

What this PR does / why we need it:
Fix umask to actually intended behavior.

Follow up to #57052

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #52999

Special notes for your reviewer:
/assign @tallclair
/cc @mikedanese @roberthbailey

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 9, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 9, 2018
@tallclair
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 9, 2018
@tallclair
Copy link
Member

tallclair commented Apr 9, 2018 •
edited
Loading

/lgtm

@tallclair tallclair added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2018
@tallclair
Copy link
Member

/assign @mikedanese

@mikedanese
Copy link
Member

mikedanese commented Apr 10, 2018 •
edited
Loading

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filbranden, mikedanese, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2018
@filbranden
Copy link
Contributor Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 60197, 61614, 62074, 62071, 62301). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 31d2287 into kubernetes:master Apr 10, 2018
This was referenced Apr 10, 2018
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 12, 2018
Merge pull request #62348 from filbranden/automated-cherry-pick-of-#6…
d4ab475 
…2301-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #62301: Fix umask to actually intended behavior.

Cherry pick of #62301 on release-1.10.

#62301: Fix umask to actually intended behavior.
@Random-Liu Random-Liu mentioned this pull request Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese Awaiting requested review from mikedanese

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@mikedanese mikedanese

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubelet bootstrap certificate is widely available after boot
6 participants
@filbranden @tallclair @mikedanese @k8s-ci-robot @fejta-bot @k8s-github-robot