New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 1.10 change log typo #62097

Merged

k8s-github-robot merged 1 commit into kubernetes:master from hzxuzhonghu:fix-change-log

Apr 10, 2018

Member

hzxuzhonghu commented Apr 4, 2018

What this PR does / why we need it:

Thanks to @christianhuening, find typo about enable-admission-plugins and disable-admission-plugins
They are plural.

Release note:

NONE


          fix typo

549fb0c

k8s-ci-robot added release-note-none size/S cncf-cla: yes labels

k8s-ci-robot requested review from dims and thockin

April 4, 2018 08:06

Member Author

hzxuzhonghu commented Apr 4, 2018

/assign @thockin

k8s-ci-robot assigned thockin

hzxuzhonghu changed the title ~~fix typo~~ fix 1.10 change log typo

Member Author

hzxuzhonghu commented Apr 4, 2018

/assign @wojtek-t
for approval

k8s-ci-robot assigned wojtek-t

Member Author

hzxuzhonghu commented Apr 4, 2018

/retest

Member Author

hzxuzhonghu commented Apr 9, 2018

kindly ping @wojtek-t @thockin

Member

thockin commented Apr 9, 2018

/lgtm
/approve no-issue

k8s-ci-robot added the lgtm label

Contributor

k8s-ci-robot commented Apr 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the approved label

fejta-bot commented Apr 9, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

4 similar comments

fejta-bot commented Apr 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Apr 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Apr 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Apr 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

k8s-github-robot commented Apr 10, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot commented Apr 10, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

k8s-github-robot merged commit da85a28 into kubernetes:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cncf-cla: yes lgtm release-note-none size/S