Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup default cni dir correctly #62055

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Setup default cni dir correctly #62055

merged 1 commit into from
Apr 11, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Apr 3, 2018

What this PR does / why we need it:

Kubelet failed to set up pod with error: failed to find plugin "loopback" in path []. This only happens when kubelet's --cni-bin-dir not set. This PR fixes this.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62054

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2018
@k8s-ci-robot k8s-ci-robot requested review from dnardo and MrHohn April 3, 2018 08:11
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2018
@feiskyer feiskyer requested a review from dcbw April 3, 2018 08:12
@feiskyer
Copy link
Member Author

feiskyer commented Apr 4, 2018

/assign @thockin

@feiskyer
Copy link
Member Author

feiskyer commented Apr 4, 2018

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Apr 4, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Apr 6, 2018

ping @thockin @dcbw

@thockin
Copy link
Member

thockin commented Apr 9, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2018
@feiskyer
Copy link
Member Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 61549, 62230, 62055, 61082, 62212). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 9d0826d into kubernetes:master Apr 11, 2018
@feiskyer feiskyer deleted the cni-bin-dir branch April 11, 2018 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnardo dnardo Awaiting requested review from dnardo

@MrHohn MrHohn Awaiting requested review from MrHohn

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to find plugin "loopback" in path []
5 participants
@feiskyer @thockin @k8s-ci-robot @fejta-bot @k8s-github-robot